Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix diags internal waves #1487

Merged
merged 3 commits into from
Sep 1, 2021

Conversation

raphaeldussin
Copy link
Contributor

diags previously not working using DIAG_AS_CHKSUM because of axes definition and/or unitialized values

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #1487 (5bea586) into dev/gfdl (a7d8e3a) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           dev/gfdl    #1487      +/-   ##
============================================
- Coverage     29.04%   29.04%   -0.01%     
============================================
  Files           236      236              
  Lines         71398    71401       +3     
============================================
  Hits          20736    20736              
- Misses        50662    50665       +3     
Impacted Files Coverage Δ
...c/parameterizations/lateral/MOM_internal_tides.F90 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7d8e3a...5bea586. Read the comment docs.

Copy link
Collaborator

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem correct to me, and I think that this can be merged after it has been updated to be based on the latest version of dev/gfdl and passes the TC and pipeline testing.

@marshallward
Copy link
Collaborator

marshallward commented Sep 1, 2021

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/13515 ✔️

@marshallward marshallward merged commit d1c0835 into mom-ocean:dev/gfdl Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants